On 01/31/2014 11:35 AM, Florian Vaussard wrote: > Hello, > > Changes sinces v1: > - Merge sja1000_of_platform.c into sja1000_platform.c (patch 4) > > The first part of this series performs serveral small cleanups > (patches 1 to 3). > > Patch 4 merges sja1000_of_platform.c into sja1000_platform.c. > Changes are pretty conservatives (mostly copy/paste/move). IRQ > is treated differently in the OF and non-OF versions, thus this > is where the fused version differs the most. > > The final part introduces the 'reg-io-width' binding (already used > by some other drivers) to perform a similar job as what was done > with IORESOURCE_MEM_XXBIT. This is needed on my system to correctly > take into account the aliasing of the address bus.
Good work, please keep compatibility for DTs without the 'reg-io-width' binding. The rest of my comments are only nitpicks. :) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
