On Tue, Jan 25, 2005 at 11:00:22AM +0300, Vasily Averin wrote: > cc: Andrey Melnikov <[EMAIL PROTECTED]> > cc: linux-kernel@vger.kernel.org > > Marcello, Andrey > > I believe this patch is wrong. > First, it prevent nothing: NMI watchdog is a signal that you wait too > long with disabled interrupts. Your controller was not answered too > long, obviously it is a hardware issue. > Second, you could not call schedule() with io_request_lock spinlock taken. > > You should unlock io_request_lock before msleep, like in latest versions > of megaraid2 drivers. > > Please fix it.
Andrey, Can you please update your patch to unlock io_request_lock before sleeping and locking after coming back? What the driver is doing is indeed wrong. Thank you. Is there anybody out there at LSI? > Thank you, > Vasily Averin, SWSoft Linux Kernel Team > > # ChangeSet > # 2005/01/19 14:16:32-02:00 [EMAIL PROTECTED] > # [PATCH] Prevent NMI oopser from triggering when megaraid2 waits > # for abort/reset cmd completion > # > # > We should backport msleep() in 2.4.29-pre1. > # > # Ok, msleep() backported, but driver isn't fixed. This patch > # acceptable? > # > # Prevent NMI oopser kill kernel thread when megaraid2 driver waiting > # abort or reset command completion. > # > # Signed-off-by: Andrey Melnikov <[EMAIL PROTECTED]> > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
