Am 10.02.2014 09:49, schrieb Geert Uytterhoeven: > On Sun, Feb 9, 2014 at 9:21 PM, Richard Weinberger <rich...@nod.at> wrote: >> Am 09.02.2014 21:15, schrieb Paul Bolle: >>> On Sun, 2014-02-09 at 21:04 +0100, Richard Weinberger wrote: >>>> Am 09.02.2014 20:38, schrieb Paul Bolle: >>>>> But now you've enabled a lot of stuff that, as far as I can tell, could >>>>> not have been built since v2.6.39. >>>> >>>> This is by design. If the code does not build/work it needs to be fixed or >>>> removed. >>> >>> If that was the design goal of this patch (and similar patches you've >>> sent) it would have been proper to at least say a few words along those >>> lines in the commit explanation. >> >> I assumed that every kernel developer is aware of that fact that >> unreachable/dead code >> should be removed. > > Yes, it should be removed. > > But that's not what you did. You did the Kconfig-equivalent of removing a > "#if 0" in a C source file, which causes havoc.
Fair point. I'll remove that code in v2. Hopefully I can catch all breakage on my testbed as many archs/configs are involved. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
