On Wed, Feb 02, 2005 at 11:39:29AM -0800, Pete Zaitcev wrote: > On Wed, 2 Feb 2005 20:11:35 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > > It's different hardware. While the ALPS pad delivers X axis in the range > > of 0 to 1000, the Synaptics pad will give X axis values from approx 1500 > > to approx 5500. This is four times the resolution - the size of the pad > > is mostly the same. > > > We need to divide by 2 for ALPS and by 8 for Synaptics, and that's > > basically all we need to do. But we must not do that by checking the pad > > manufacturer, because when a third pad type comes in (Say Logitech > > TouchPad 3), we shouldn't need to modify mousedev.c > > What you say is valid. I see now that this is what had to be addressed by > this statement: > size = dev->absmax[ABS_Y] - dev->absmin[ABS_Y]; > > Removing that was my mistake and I wish I had a different pad for testing. > I'll do some measurements here and return something of that nature into > the patched code and give it a try.
OK. > But I still think that using yres here is wrong. It may be a fine idea, > but adding another divisor here ruined the precision of small movements. > This was my problem. Trying to line up two windows was hugely frustrating > with 2.6.11-rc2 & Peter's patches. But also, it was unnecessary to use yres, > because the reach or maximum moving distance is to be accomplished with > ballistics, not scaling. I agree. If one wants full precision even at the ballistic speeds of movement (and Synaptics can do that simply by not dividing the values), one can use the special X driver. No need to be overclever in mousedev. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/