> >> > +#include <linux/device.h> > >> > +#include <linux/mfd/core.h> > >> > +#include <linux/module.h> > >> > +#include <linux/i2c.h> > >> > >> Please arrange these alphabetically. > > > > Why? > > 1. It makes it easier to avoid adding duplicate includes. > 2. Code looks more ordered/organized. > 3. Prevents further clean up patches arranging them so :)
I wouldn't accept any patches doing such worthless things. ;) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
