On 02/10/2014 09:23 PM, Oleg Nesterov wrote: > On 02/06, Srivatsa S. Bhat wrote: >> >> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c >> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c >> @@ -319,7 +319,7 @@ static __init int thermal_throttle_init_device(void) >> if (!atomic_read(&therm_throt_en)) >> return 0; >> >> - register_hotcpu_notifier(&thermal_throttle_cpu_notifier); >> + cpu_maps_update_begin(); >> >> #ifdef CONFIG_HOTPLUG_CPU >> mutex_lock(&therm_cpu_lock); >> @@ -333,6 +333,9 @@ static __init int thermal_throttle_init_device(void) >> mutex_unlock(&therm_cpu_lock); >> #endif >> >> + __register_hotcpu_notifier(&thermal_throttle_cpu_notifier); >> + cpu_maps_update_done(); > > > Off-topic, but it seems that after this change therm_cpu_lock can die. > Of course this needs another patch (if I am right). >
I'm not sure I understood that clearly. Can you please explain? I'm guessing that you are referring to some problem with the #ifdef CONFIG_HOTPLUG_CPU around mutex_lock/unlock(&therm_cpu_lock) ? Regards, Srivatsa S. Bhat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
