Oh.. I see. My tabstop size is 4 in my editor so I didn't get your comment. Sorry for that.(I know tabs in kernel are 8 char.)
I will re-send fixing alignment as your comment. Thanks a lot. Daeseok Youn 2014-02-11 9:20 GMT+09:00 Joe Perches <[email protected]>: > On Tue, 2014-02-11 at 09:11 +0900, DaeSeok Youn wrote: >> Hi, > > Hello. > >> Thanks for review. >> If I send this patch again, i will use a subject as you comment. > > Thanks. > >> And alignment issue, my patch line seems to be same with your example. > > You took out a space from the line with the function pointer > but not from the subsequent lines of the arguments. > >> >> diff --git a/drivers/staging/android/ion/ion.c >> >> b/drivers/staging/android/ion/ion.c >> > [] >> >> @@ -55,7 +55,7 @@ struct ion_device { >> >> struct mutex buffer_lock; >> >> struct rw_semaphore lock; >> >> struct plist_head heaps; >> >> - long (*custom_ioctl) (struct ion_client *client, unsigned int cmd, >> >> + long (*custom_ioctl)(struct ion_client *client, unsigned int cmd, >> >> unsigned long arg); >> > >> > Please realign the arguments to the open parenthesis like: >> > >> > long (*custom_ioctl)(struct ion_client *client, unsigned int cmd, >> > unsigned long arg); > > Your patch has: > > long (*custom_ioctl)(struct ion_client *client, unsigned int cmd, > unsigned long arg); > > it should be: > > long (*custom_ioctl)(struct ion_client *client, unsigned int cmd, > unsigned long arg); > > with the "unsigned long arg" aligned immediately after > the open parenthesis of the function arguments. > > (under the "s" of struct, not the first "t" of struct) > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
