On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones <lee.jo...@linaro.org> wrote: >> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare <jdelv...@suse.de> wrote: >> >> > Additionally, dashes are explicitly forbidden in hwmon >> >> > device names. >> >> >> >> Also, where is that documented? >> > >> > In Documentation/hwmon/sysfs-interface: >> > >> > ********************* >> > * Global attributes * >> > ********************* >> > >> > name The chip name. >> > This should be a short, lowercase string, not containing >> > spaces nor dashes, representing the chip name. This is >> > the only mandatory attribute. >> > I2C devices get this attribute created automatically. >> > RO >> >> Time to revisit this decision.... >> >> So, based on the fact that children device names usually contain >> dashes, I do not understand why hwmon would be any special in this >> regard. It is possible that the hwmon developers have not faced much >> MFD situation before, and so, this was not considered to be handled >> like in other subsystems. >> >> I am proposing to change this "rule"... Any objection? > > Prior to proposing such an invasive change which is highly likely to > come up against heavy opposition, why don't you try to work _with_ the > current ruling and the Maintainers to see what others have done to > solve the problem. I highly doubt you are the first/only developer who > has had this issue. > > Do: > `git grep "\-hwmon"` > > ... and have a good look around for an accepted solution.
Well, this did not bring up relevant results, at least for my understanding, but I will send a new patch with the devm_hwmon_device_register_ with_groups() stuff based on my little understanding without further help. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
