> v2: Resend due to mail format issues. More Thunderbird settings applied. > > I know very little of this code, and I'm not sure this is a good solution, > so here's some background:
I wouldn't worry too much. I'm amazed the code even works these days. It's incredibly bitrotted and doesn't use the tty layer properly (mind you it never did) > The effect of this is that /dev/ttyUSB* is still in use, and thus leaking > at least dev nodes. This is a minimal patch that solves that oops. > --- linux-3.12/drivers/net/irda/irtty-sir.c.orig 2014-02-12 > 21:36:46.132496089 +0000 > +++ linux-3.12/drivers/net/irda/irtty-sir.c 2014-02-12 21:57:21.635843884 > +0000 > @@ -521,7 +521,6 @@ static void irtty_close(struct tty_struc > sirdev_put_instance(priv->dev); > > /* Stop tty */ > - irtty_stop_receiver(tty, TRUE); > clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags); > if (tty->ops->stop) > tty->ops->stop(tty); This change looks correct to me. The three lines below your change are amusing all incorrect and should probably also all be deleted. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
