From: Andreas Gruenbacher <[email protected]> Right now every resource has exactly one connection. But we are preparing for dynamic connections. I.e. in the future thre can be resources without connections.
However smatch points this out as 'variable dereferenced before check', which is correct. This issue was introduced in drbd: get_one_status(): Iterate over resource->devices instead of connection->peer_devices Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Andreas Gruenbacher <[email protected]> Signed-off-by: Philipp Reisner <[email protected]> --- drivers/block/drbd/drbd_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 2086b12..526414b 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -2776,7 +2776,7 @@ static int nla_put_drbd_cfg_context(struct sk_buff *skb, if (device && nla_put_u32(skb, T_ctx_volume, device->vnr)) goto nla_put_failure; - if (nla_put_string(skb, T_ctx_resource_name, connection->resource->name)) + if (nla_put_string(skb, T_ctx_resource_name, resource->name)) goto nla_put_failure; if (connection) { if (connection->my_addr_len && -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
