On Sat, Feb 22, 2014 at 12:09:30PM -0500, Theodore Ts'o wrote: > On Fri, Feb 21, 2014 at 12:07:41AM +0900, Namjae Jeon wrote: > > From: Namjae Jeon <[email protected]> > > > > This patch implements fallocate's FALLOC_FL_COLLAPSE_RANGE for Ext4. > > > > The semantics of this flag are following: > > 1) It collapses the range lying between offset and length by removing any > > data > > blocks which are present in this range and than updates all the logical > > offsets of extents beyond "offset + len" to nullify the hole created by > > removing blocks. In short, it does not leave a hole. > > 2) It should be used exclusively. No other fallocate flag in combination. > > 3) Offset and length supplied to fallocate should be fs block size aligned > > in case of xfs and ext4. > > 4) Collaspe range does not work beyond i_size. > > > > Signed-off-by: Namjae Jeon <[email protected]> > > Signed-off-by: Ashish Sangwan <[email protected]> > > Tested-by: Dongsu Park <[email protected]> > > In terms of how to get this upstream, it looks like if we do something > like this, we can let this patch go via the ext4 tree and we don't > need to worry about whether the vfs level changes have gone in our > not. > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index ad13359..d7a78ed 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -46,6 +46,10 @@ > > #include <trace/events/ext4.h> > > +#ifndef FALLOC_FL_COLLAPSE_RANGE > +#define FALLOC_FL_COLLAPSE_RANGE 0x08 > +#endif > + > /* > * used by extent splitting. > */
You're more than welcome to do that, Ted. Just wait until we get the VFS part into the XFS tree first ;) Cheers, Dave. -- Dave Chinner [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
