On Mon, Feb 24, 2014 at 03:52:24PM +0000, Austin, Brian wrote: > >> + if (!IS_ERR(cs42888->clk)) > >> + clk_disable_unprepare(cs42888->clk); > > > > Does the device work without MCLK? > Yes, MCLK is required. If you can’t get the clock you should error out.
Wait...Regarding this clock part, I just forgot the reason I put the code: 385 cs42888->clk = devm_clk_get(&i2c->dev, "mclk"); 386 if (IS_ERR(cs42888->clk)) 387 dev_warn(&i2c->dev, "failed to get the clock: %ld\n", 388 PTR_ERR(cs42888->clk)); was because the MCLK might be provided from SoC (DAI master) so it could be totally controlled by CPU DAI driver, ESAI for example has its own dividers to derive the HCKT clock (MCLK for Tx) from ahb clock in SoC clock tree, in which case we might not easily pass a valid clock phandle via DT. (RFC to this thought.) Thank you, Nicolin Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
