On Sun, Feb 23, 2014 at 08:23:35PM -0600, miny...@acm.org wrote: > @@ -1194,7 +1223,17 @@ int ipmi_set_gets_events(ipmi_user_t user, int val) > INIT_LIST_HEAD(&msgs); > > spin_lock_irqsave(&intf->events_lock, flags); > - user->gets_events = val; > + if (user->gets_events == !!val) > + goto out; > + > + user->gets_events = !!val;
Why not have val declared as bool and let compiler convert as needed? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
