On Mon, Feb 24, 2014 at 05:04:57PM -0500, Tom Rini wrote: > On 02/24/2014 05:02 PM, Joe Perches wrote: > > On Mon, 2014-02-24 at 16:52 -0500, Tom Rini wrote: > >> I've been lead to > >> believe that most cases now people should be using regmap instead, which > >> just leaves the case of having to match on-disk formats or similar cases > >> I believe as the things that must stay __packed. > > > > __packed is also necessary for on-wire networking protocols. > > Indeed, and there's probably a few other valid cases I'm also > forgetting. But the common case is hardware, where regmap is now preferred.
Except on s390 which doesn't use regmap. So this will give us a lot of false positives with a warning message that isn't helpful at all. It doesn't even tell us why it could be problematic and what would be the better choice. > I've got this modified to a CHK and only for non-file usage. Anything > else we want to talk about before I repost? /me thinks this patch should be dropped. It would cause too many false positives, since there are lot of valid use cases for __packed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
