At Tue, 25 Feb 2014 21:21:18 -0500, MUNEDA Takahiro wrote: > > On Mon, 24 Feb 2014 09:30:39 -0500, > Steven Rostedt <[email protected]> wrote: > > > On Sun, 23 Feb 2014 10:19:28 +0900 > > Satoru Takeuchi <[email protected]> wrote: > > > >> From: Satoru Takeuchi <[email protected]> > >> > >> As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console' > >> with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL > >> in the kvm.conf. > >> > >> Signed-off-by: Satoru Takeuchi <[email protected]> > >> Cc: Steven Rostedt <[email protected]> > >> --- > >> tools/testing/ktest/examples/kvm.conf | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/tools/testing/ktest/examples/kvm.conf > >> b/tools/testing/ktest/examples/kvm.conf > >> index 831c7c5..40356f7 100644 > >> --- a/tools/testing/ktest/examples/kvm.conf > >> +++ b/tools/testing/ktest/examples/kvm.conf > >> @@ -10,6 +10,10 @@ MACHINE = Guest > >> # Use virsh to read the serial console of the guest > >> CONSOLE = virsh console ${MACHINE} > >> > >> +# Use SIGILL to terminate virsh console. We can't kill virsh console > >> +# by the default signal, SIGINT. > >> +CLOSE_CONSOLE_SIGNAL = KILL > >> + > > > > Thanks, I'll add this to my 3.15 queue. > > Hmm, it seems that we need a following patch as well. > Or, please merge with the orignal patch. > > Thanks, > Takahiro > > ====================================================================== > From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001 > From: MUNEDA Takahiro <[email protected]> > Date: Tue, 25 Feb 2014 15:32:35 -0500 > Subject: [PATCH] ktest: Fixes a trivial typo > > Signed-off-by: MUNEDA Takahiro <[email protected]> > Cc: Satoru Takeuchi <[email protected]> > Cc: Steven Rostedt <[email protected]> > > --- > tools/testing/ktest/examples/kvm.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/ktest/examples/kvm.conf > b/tools/testing/ktest/examples/kvm.conf > index 40356f7..fbc134f 100644 > --- a/tools/testing/ktest/examples/kvm.conf > +++ b/tools/testing/ktest/examples/kvm.conf > @@ -10,7 +10,7 @@ MACHINE = Guest > # Use virsh to read the serial console of the guest > CONSOLE = virsh console ${MACHINE} > -# Use SIGILL to terminate virsh console. We can't kill virsh console > +# Use SIGKILL to terminate virsh console. We can't kill virsh console
Oops, it's a completely the different signal. Thanks Takahiro. Satoru > # by the default signal, SIGINT. > CLOSE_CONSOLE_SIGNAL = KILL > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
