On Thursday, February 27, 2014 11:15:05 AM Kieran Clancy wrote: > On Thu, Feb 27, 2014 at 10:15 AM, Rafael J. Wysocki <[email protected]> > wrote: > > On Thursday, February 27, 2014 02:12:40 AM Kieran Clancy wrote: > >> Signed-off-by: Kieran Clancy <[email protected]> > >> Signed-off-by: Lan Tianyu <[email protected]> > >> Signed-off-by: Juan Manuel Cabo <[email protected]> > >> Signed-off-by: Dennis Jansen <[email protected]> > > > > There are too many sign-offs under this patch. I suppose some of them > > should be Acked-by or Reviewed-by. > > > > Are you the author? > > Sorry about that, I wasn't sure of the best way to acknowledge the > people involved. > > I am the primary author, but I based the loop which calls > acpi_ec_query_unlocked() on a patch by Lan Tianyu. Juan provided the > initial idea (userspace workaround), and Dennis and Lan Tianyu > reviewed and suggested some changes to the code. > > What would you usually do this kind of situation?
I usually add acknowledgements to the changelog without using any tags, like "This patch is based on previous work by <somebody>." And then you can give a link to that work in References:. > I suppose I could put something such as: > > Signed-off-by: Kieran Clancy <[email protected]> > Signed-off-by: Lan Tianyu <[email protected]> > Suggested-by: Juan Manuel Cabo <[email protected]> > Reviewed-by: Lan Tianyu <[email protected]> > Reviewed-by: Dennis Jansen <[email protected]> > > Would this be preferable? Yes, that'd be fine by me. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
