On Fri, Feb 28, 2014 at 02:33:16PM -0500, Steven Rostedt wrote: > [ H. Peter, Here's the rename patch. I did not include your update. You > can add that first and then massage this patch on top. But this isn't > critical for mainline or stable, where as I believe your patch is. ] > > The tracing utilities sometimes need to read from userspace (stack tracing), > and to do this it has as special copy_from_user function called > copy_from_user_nmi(). Well, as tracers can call this from outside of > nmi context, the "_nmi" part is a misnomer and "_trace" is a better > name.
NAK, spin_lock_irq() is very much an IRQ safe lock. Similarly copy_from_user_nmi() is an NMI safe copy from user. Furthermore, there's exactly 0 trace users, so the proposed name is actively worse. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/