Andi Kleen <a...@firstfloor.org> writes: > From: Andi Kleen <a...@linux.intel.com> > > For lbr-as-callgraph we need to see the line number in the history, > because many LBR entries can be in a single function, and just > showing the same function name many times is not useful.
This patch broke the GTK build, fixed with this followon patch: >From fd2b85cc85534f3a3b025b36bab6c42d31edc660 Mon Sep 17 00:00:00 2001 From: Andi Kleen <a...@linux.intel.com> Date: Fri, 28 Feb 2014 16:53:40 -0800 Subject: [PATCH] perf, tools: Fix gtk compilation with src line patch. Convert the gtk browser code to the new shared callchain_list__sym_name function too. Should be folded into "perf, tools: Enable printing the srcline in the history" Signed-off-by: Andi Kleen <a...@linux.intel.com> diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c index 5b95c44..cafe105 100644 --- a/tools/perf/ui/gtk/hists.c +++ b/tools/perf/ui/gtk/hists.c @@ -123,15 +123,6 @@ void perf_gtk__init_hpp(void) perf_gtk__hpp_color_overhead_guest_us; } -static void callchain_list__sym_name(struct callchain_list *cl, - char *bf, size_t bfsize) -{ - if (cl->ms.sym) - scnprintf(bf, bfsize, "%s", cl->ms.sym->name); - else - scnprintf(bf, bfsize, "%#" PRIx64, cl->ip); -} - static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store, GtkTreeIter *parent, int col, u64 total) { @@ -162,7 +153,7 @@ static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store, scnprintf(buf, sizeof(buf), "%5.2f%%", percent); gtk_tree_store_set(store, &iter, 0, buf, -1); - callchain_list__sym_name(chain, buf, sizeof(buf)); + callchain_list__sym_name(chain, buf, sizeof(buf), false); gtk_tree_store_set(store, &iter, col, buf, -1); if (need_new_parent) { -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/