On Fri, 28 Feb 2014, Benjamin Tissoires wrote: > I don't have access to the device, so I copied/pasted the code > from hidraw. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > --- > drivers/hid/hid-cp2112.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c > index 860db694..c4f87bd 100644 > --- a/drivers/hid/hid-cp2112.c > +++ b/drivers/hid/hid-cp2112.c > @@ -290,7 +290,21 @@ static int cp2112_hid_output(struct hid_device *hdev, u8 > *data, size_t count, > if (!buf) > return -ENOMEM; > > - ret = hdev->hid_output_raw_report(hdev, buf, count, report_type); > + /* Fixme: test which function is actually called for output reports */
I don't completely understand this Fixme (oh, and please spell it as 'FIXME:' so that we are consistent with all the other instances), could you please elaborate? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
