On 04/03/14 21:21, Randy Dunlap wrote: >> I have pushed this to my for-next branch. Let's see what happens... At >> least I'm able to merge the current linux-next without any conflicts. > > Thanks, I'm looking at this change in linux-next now. > > EXYNOS_VIDEO seems to be a little bit odd. Can you clarify that for me? > (This is not a change that you introduced.) > > > In particular, under Graphics support, select Framebuffer Devices. > This lists: > Support for frame buffer devices --> > Exynos Video driver support > > It appears to me that Exynos either is a Framebuffer Device and should depend > on FB like the other drivers here do OR (actually XOR) it is not a frame > buffer > device and it should not be listed here. > > Then once that is cleared up :), we don't need 2 levels of menu to get to the > list of FB drivers -- i.e., one of those levels can be removed.
There are others. For my config, I have:
{*} Support for frame buffer devices --->
<M> OMAP2+ Display Subsystem support --->
[ ] Exynos Video driver support ----
< > Solomon SSD1307 framebuffer support
I didn't want to start fixing those at the moment, as I have no idea
about exynos or solomon, and I wanted to just try to do the reorder,
without any other changes.
I agree that there's something wrong with the items. For the OMAP DSS,
there are non-fbdev related items under that menu, used also by omapdrm.
So it should probably be split into different components.
> Oh, and if you keep the new menu item "Framebuffer Devices", please spell it
> like the other entry (Frame Buffer).
Ok, fixed.
> Other than those nits, I like this change very much. Thanks.
Thanks. After pushing this to for-next, I'm getting compile error
reports from Fengguang and Stephen. Let's see if I manage to avoid
those... This is not the easiest change to manage.
Tomi
signature.asc
Description: OpenPGP digital signature
