On Thu, Feb 03, 2005 at 12:08:05PM -0700, Bjorn Helgaas wrote: > Convert pci_raw_ops to use unsigned segment (aka domain), > bus, and devfn. With the previous code, various ia64 config > accesses fail due to segment sign-extension problems. > > ia64: > - With a signed seg >= 0x8, unwanted sign-extension occurs when > "seg << 28" is cast to u64 in PCI_SAL_EXT_ADDRESS() > - PCI_SAL_EXT_ADDRESS(): cast to u64 *before* shifting; otherwise > "seg << 28" is evaluated as unsigned int (32 bits) and gets > truncated when seg > 0xf > - pci_sal_read(): validate "value" ptr as other arches do > - pci_sal_{read,write}(): return -EINVAL rather than SAL error status > > arch/i386/pci/direct.c | 12 ++++++---- > arch/i386/pci/mmconfig.c | 6 +++-- > arch/i386/pci/numa.c | 6 +++-- > arch/i386/pci/pcbios.c | 6 +++-- > arch/ia64/pci/pci.c | 53 > ++++++++++++++++++--------------------------- > arch/x86_64/pci/mmconfig.c | 8 ++++-- > include/linux/pci.h | 6 +++-- > 7 files changed, 51 insertions(+), 46 deletions(-) > > Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
Applied, thanks. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/