Em Fri, Mar 07, 2014 at 04:51:00PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Mar 07, 2014 at 02:19:49PM +0100, Jiri Olsa escreveu: > > On Thu, Feb 27, 2014 at 08:22:26PM -0800, Andi Kleen wrote: > > > +static void resolve_branch_ams(struct machine *machine, struct thread > > > *thread, > > > + u64 ip, > > > + struct addr_location *al)
> > the function name is confusing.. there's no branch or ams > > being dealt with in here > yeah, it should be renamed, and all it does is to try to find something > in all the possible cpu modes, so I think we should rename this to: > thread__find_cpumode_addr_location() > And move it to right after thread__find_addr_location(), then use it > here, doing that and combining the other patches, etc, should have it in > a place for testing soon. > > > maybe something like resolve_ip_al or resolve_ip ? Humm, then it gets overly long and we have PERF_RECORD_MISC_CPUMODE_UNKNOWN, so I'll try making it so that if cpumode is passed as PERF_RECORD_MISC_CPUMODE_UNKNOWN, thread__find_addr_location() will try to figure it out. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/