Hi Steven,
At Sun, 02 Mar 2014 21:20:31 +0900,
Satoru Takeuchi wrote:
>
> From: Satoru Takeuchi <satoru.takeu...@gmail.com>
>
> If we'd like to set the redirect target file of run_command(),
> we should define $redirect before calling this function and should undef it
> after calling this function. Since it's user-unfriendly, add 2nd parameter of
> run_command() for this purpose.
>
> Signed-off-by: Satoru Takeuchi <satoru.takeu...@gmail.com>
> Cc: Steven Rostedt <rost...@goodmis.org>
Could you tell whether this patch will be applied? Although you told me that you
won't apply the following patch, I didn't hear about this patch.
> [PATCH 2/2] ktest: run make mrproper not only for OUTPUT_DIR but also for
> BUILD_DIR to avoid build failure
I make this question since I'll send next patch set this weekend and want to
know whether I can make patch on the top of this patch.
Thanks,
Satoru
> ---
> tools/testing/ktest/ktest.pl | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index 4063156..f731ef6 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -149,7 +149,6 @@ my $bisect_ret_abort;
> my $bisect_ret_default;
> my $in_patchcheck = 0;
> my $run_test;
> -my $redirect;
> my $buildlog;
> my $testlog;
> my $dmesg;
> @@ -1529,7 +1528,7 @@ sub fail {
> }
>
> sub run_command {
> - my ($command) = @_;
> + my ($command, $redirect) = @_;
> my $dolog = 0;
> my $dord = 0;
> my $pid;
> @@ -2265,9 +2264,7 @@ sub build {
> # Run old config regardless, to enforce min configurations
> make_oldconfig;
>
> - $redirect = "$buildlog";
> - my $build_ret = run_command "$make $build_options";
> - undef $redirect;
> + my $build_ret = run_command "$make $build_options", $buildlog;
>
> if (defined($post_build)) {
> # Because a post build may change the kernel version
> @@ -2360,9 +2357,7 @@ sub child_run_test {
> $poweroff_on_error = 0;
> $die_on_failure = 1;
>
> - $redirect = "$testlog";
> - run_command $run_test or $failed = 1;
> - undef $redirect;
> + run_command $run_test, $testlog or $failed = 1;
>
> exit $failed;
> }
> --
> 1.8.5.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
