On Mon, Mar 10, 2014 at 06:29:36PM +0200, Michael S. Tsirkin wrote: > skb_segment copies frags around, so we need > to copy them carefully to avoid accessing > user memory after reporting completion to userspace > through a callback. > > skb_segment doesn't normally happen on datapath: > TSO needs to be disabled - so disabling zero copy > in this case does not look like a big deal. > > Signed-off-by: Michael S. Tsirkin <[email protected]>
Why do we need this patch at all? Contrary to what you said, this path is definitely performance-critical since the basis of being able to enable GSO by default is that it causes no regressions in non-TSO cases. Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
