> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this > doesn't match the exact name of the configuration option. > This warning showed up once to me when I was starting to set up BCH. After > checking my .config file, it took a moment before realizing it is > CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH. > > Signed-off-by: Erico Nunes <[email protected]> > --- > drivers/mtd/nand/nand_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 9715a7b..5a93787 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -3825,7 +3825,7 @@ int nand_scan_tail(struct mtd_info *mtd) > > case NAND_ECC_SOFT_BCH: > if (!mtd_nand_has_bch()) { > - pr_warn("CONFIG_MTD_ECC_BCH not enabled\n"); > + pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n"); > BUG(); > } > ecc->calculate = nand_bch_calculate_ecc;
Not sure if CONFIG options should be printed in the log at all, but the correct option is better than an incorrect one. Seeing as CONFIG_MTD_ECC_BCH doesn't actually exist: Acked-by: Lee Jones <[email protected]> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
