On Tue, Mar 11, 2014 at 04:25:02PM +0100, Jiri Olsa wrote:
> On Tue, Mar 11, 2014 at 01:31:54AM +0100, Andi Kleen wrote:
> > > this is *same* as parse_branch_mode function and seems to be not needed,
> > > I think both branch-stack and branch-history options could be handled
> > > by OPT_BOOLEAN
> > 
> > They can't because the type checker requires bool, and these variables
> > are tristate (UNSET, TRUE, FALSE)
> > 
> > -Andi
> 
> hum, I can see only 2 states there (please check patch below).. what do I 
> miss?

-1 means undefined. Your patch changes things that the override would
happen even if the user explicitely set these options. It's not
equivalent.


-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to