On Sat, Mar 8, 2014 at 11:14 AM, Paul Bolle <[email protected]> wrote: > On Sat, 2014-03-08 at 10:58 -0800, Andy Lutomirski wrote: >> Some of them are errors; some are not. Annotate them accordingly. >> >> Signed-off-by: Andy Lutomirski <[email protected]> >> --- >> lib/raid6/algos.c | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c >> [...] >> @@ -194,7 +195,7 @@ int __init raid6_select_algo(void) >> syndromes = (void *) __get_free_pages(GFP_KERNEL, 1); >> >> if (!syndromes) { >> - printk("raid6: Yikes! No memory available.\n"); >> + printk(KERN_ERR "raid6: Yikes! No memory available.\n"); >> return -ENOMEM; >> } >> > > Does __get_free_pages() print and error (or similar) when it fails? If > so, this printk() could be dropped, couldn't it?
I think it does in warn_alloc_failed in mm/page_alloc.c. It might not be clear what the impact of that error is, but, empirically, if there's too little memory during boot, everything is thoroughly broken anyway. > > > Paul Bolle > -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
