On Fri, Mar 14, 2014 at 11:53:30AM +0100, Linus Walleij wrote: > On Thu, Mar 13, 2014 at 4:18 PM, Mika Westerberg > <mika.westerb...@linux.intel.com> wrote: > > On Thu, Mar 13, 2014 at 03:32:01PM +0100, Linus Walleij wrote: > > >> > + case ACPI_IO_RESTRICT_OUTPUT: > >> > + gpiod_direction_output(desc, pull); > >> > >> Can you explain why the fact that the line is pulled down affects the > >> default output value like this? I don't get it. > > > > That's the thing - ACPI doesn't tell us what is the initial value of the > > pin. There is no such field in GpioIo() resource. > > > > So I'm assuming here that if it says that the pin is pulled up, the default > > value will be high. > > OK! So exactly that statement is what I want to see as a comment > in this switch case.
Sure. I'll add that comment to the next version of this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
