On Sun, 2014-03-16 at 14:35 +0200, Tomas Winkler wrote:
> use cl_dbg for debug log messages in cl context
I think all the uses of cl_dbg and cl_err are odd.
from: client.h
#define cl_dbg(dev, cl, format, arg...) \
dev_dbg(&(dev)->pdev->dev, MEI_CL_FMT format, MEI_CL_PRM(cl), ##arg)
#define cl_err(dev, cl, format, arg...) \
dev_err(&(dev)->pdev->dev, MEI_CL_FMT format, MEI_CL_PRM(cl), ##arg)
dev is always passed separately from cl but
dev is set like:
struct mei_device *dev;
[]
dev = cl->dev;
So I think these should be converted to:
#define cl_dbg(cl, format, ...) \
dev_dbg(&(cl)->dev)->pdev->dev, MEI_CL_FMT format, MEI_CL_PRM(cl),
##__VA_ARGS__)
and the uses from (as an example):
client.c:942: cl_dbg(dev, cl, "Waking up reading client!\n");
to
client.c:942: cl_dbg(cl, "Waking up reading client!\n");
This can also remove some used once declarations of dev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
