On Thu, Mar 20, 2014 at 09:20:32AM +0000, Lee Jones wrote: > This should be the final version (again) :) > > Version 6: > Serviced 3 nits picked up by Brian during final review.
I'm really sorry to do this again, but can you *please* read *all* of my comments? You're missing at least the following diff! I'm fine with an incremental patch on top of this series. diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c index aefd48db7ade..6369636e980a 100644 --- a/drivers/mtd/devices/st_spi_fsm.c +++ b/drivers/mtd/devices/st_spi_fsm.c @@ -3,7 +3,7 @@ * * Author: Angus Clark <[email protected]> * - * Copyright (C) 2010-2014 STicroelectronics Limited + * Copyright (C) 2010-2014 STMicroelectronics Limited * * JEDEC probe based on drivers/mtd/devices/m25p80.c * @@ -1730,14 +1730,6 @@ static int stfsm_mtd_write(struct mtd_info *mtd, loff_t to, size_t len, dev_dbg(fsm->dev, "%s to 0x%08x, len %zd\n", __func__, (u32)to, len); - *retlen = 0; - - if (!len) - return 0; - - if (to + len > mtd->size) - return -EINVAL; - /* Offset within page */ page_offs = to % FLASH_PAGESIZE; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
