On 03/21/2014 12:43 PM, Alexandre Belloni wrote:

Alexandre,

Thanks for starting this! I'll start with the most obvious
things first and have a closer look on it later.

Missing commit description here.

Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
---
  arch/arm/boot/dts/berlin2q.dtsi | 20 ++++++++++++++++++--
  1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 07452a7483fa..19d2c82b0664 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -59,10 +59,26 @@
                clock-frequency = <100000000>;
        };

+       syspll: syspll {

syspll: pll@ea0030 {

and sort it in between other SoC nodes below. This will
most likely break clocks in v3.14 but v3.15 will receive
proper clock init ordering.

+               compatible = "marvell,berlin2q-pll";
+               clocks = <&smclk>;
+               #clock-cells = <0>;
+               reg = <0xf7ea0030 8>;
+       };
+
+       cpupll: cpupll {

dito.

+               compatible = "marvell,berlin2q-pll";
+               clocks = <&smclk>;
+               #clock-cells = <0>;
+               reg = <0xf7dd0170 8>;
+       };
+
        cpuclk: cpu-clock {
-               compatible = "fixed-clock";
+               compatible = "fixed-factor-clock";
+               clocks = <&cpupll>;
                #clock-cells = <0>;
-               clock-frequency = <1200000000>;
+               clock-div = <1>;
+               clock-mult = <1>;

Hmm, you probably know better than me, but if cpuclk == cpupll
is always true we don't need another clk layer here. If you
can scale down cpuclk from cpupll and we just have no driver
for it, I am fine with it.

Sebastian

        };

        twdclk: twdclk {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to