On Mon, Feb 14, 2005 at 01:02:05PM +0100, Andi Kleen wrote:
> On Mon, Feb 14, 2005 at 10:47:01AM +0100, Piotr Kaczuba wrote:
> > On Mon, Feb 14, 2005 at 10:18:43AM +0100, Andi Kleen wrote:
> > > Piotr Kaczuba <[EMAIL PROTECTED]> writes:
> > > > Is there a reason why "PCI access mode" config option isn't available
> > > > for
> > > > x86_64? Due to this, PCIE config options aren't available either.
> > >
> > > There is no 64bit PCI BIOS, so access is always direct.
> > >
> > > I assume you mean mmconfig access with "PCIE config options", that is
> > > a separate config option and available.
> >
> > I mean the PCIEPORTBUS option which depends on PCI_GOMMCONFIG or
> > PCI_GOANY. I assume that due to PCI_MMCONFIG / PCI_GOMMCONFIG mismatch
> > it's not available on x86_64.
>
> Ok, that's a bug in PCIEPORTBUS. Best is probably to
> completely remove the dependency, it doesn't make much sense
> (the code has to handle the case of mmconfig not being available at
> runtime anyways)
>
> -Andi
>
> Remove bogus dependency in PCI Express root driver.
>
> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>
>
> diff -u linux-2.6.11rc3/drivers/pci/pcie/Kconfig-o
> linux-2.6.11rc3/drivers/pci/pcie/Kconfig
> --- linux-2.6.11rc3/drivers/pci/pcie/Kconfig-o 2005-02-04
> 09:13:10.000000000 +0100
> +++ linux-2.6.11rc3/drivers/pci/pcie/Kconfig 2005-02-14 12:59:46.000000000
> +0100
> @@ -3,7 +3,6 @@
> #
> config PCIEPORTBUS
> bool "PCI Express support"
> - depends on PCI_GOMMCONFIG || PCI_GOANY
> default n
>
> ---help---
>
This one is needed, too.
Piotr Kaczuba
--- linux.old/arch/x86_64/Kconfig 2005-02-14 16:37:33.000000000 +0100
+++ linux/arch/x86_64/Kconfig 2005-02-14 16:37:18.000000000 +0100
@@ -399,6 +399,8 @@
from i386. Requires that the driver writer used memory barriers
properly.
+source "drivers/pci/pcie/Kconfig"
+
source "drivers/pci/Kconfig"
source "drivers/pcmcia/Kconfig"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
