> + * You should have received a copy of the GNU General Public License along
> with
> + * this program; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
We're not supposed to use the address anymore.
> +/* memory allocation flag */
> +#define KTAP_ALLOC_FLAGS ((GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN) \
> + & ~__GFP_WAIT)
> +
> +void *kp_malloc(ktap_state_t *ks, int size)
> +{
> + void *addr;
> +
> + addr = kmalloc(size, KTAP_ALLOC_FLAGS);
> + if (unlikely(!addr)) {
> + kp_error(ks, "kmalloc failed\n");
> + }
> + return addr;
Please remove this pointless wrapper. Similar for the functions below.
Just use kmalloc etc. directly.
> + case KTAP_TNUM:
> + kp_printf(ks, "NUM %ld", nvalue(v));
Similar here. That's all printk
-Andi
--
[email protected] -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
