On Mon, Mar 31, 2014 at 5:17 PM, Linus Torvalds
<torva...@linux-foundation.org> wrote:
>
> So what I would propose is:
>
> - don't do the __visible as part of asmlinkage, because it really is
> conceptually wrong
>
> - add the visible to the SYSCALL_DEFINEx() macros
>
> and after that I strongly suspect that there will be only a handful of
> cases left that are called from assembly language and that aren't
> system calls. Things like "printk()" and friends that are really
> special. They'd need a few manual "__visible" annotations.
I notice that there seems to be a handful of x86 system calls that
don't use the SYSCALL_DEFINEx() macros to define the system call, some
grepping finds at least ioperm(), modify_ldt(), sigreturn() and
rt_sigreturn(). There are probably others. They should just be
converted to SYSCALL_DEFINEx() while at it. No, x86 doesn't need the
typecasting, but it won't hurt either, and it's good to be consistent.
I'm not sure why those system calls didn't get converted (other
x86-specific ones like vm86() _have_ gotten converted), maybe there's
some reason for it. But I *think* the reason is "nobody noticed".
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
