On Thu, Apr 03, 2014 at 09:55:37PM +0200, Thomas Bächler wrote: > Commit 9e30cc9595303b27b48 removed an internal mount. This > has the side-effect that rootfs now has FSID 0. Many > userspace utilities assume that st_dev in struct stat > is never 0, so this change breaks a number of tools in > early userspace. > > Since we don't know how many userspace programs are affected, > make sure that FSID is at least 1. > > References: http://article.gmane.org/gmane.linux.kernel/1666905 > References: > http://permalink.gmane.org/gmane.linux.utilities.util-linux-ng/8557 > Cc: 3.14 <sta...@vger.kernel.org> > Signed-off-by: Thomas Bächler <tho...@archlinux.org> > --- > fs/super.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/super.c b/fs/super.c > index 80d5cf2..7624267 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -802,7 +802,10 @@ void emergency_remount(void) > > static DEFINE_IDA(unnamed_dev_ida); > static DEFINE_SPINLOCK(unnamed_dev_lock);/* protects the above */ > -static int unnamed_dev_start = 0; /* don't bother trying below it */ > +/* Many userspace utilities consider an FSID of 0 invalid. > + * Always return at least 1 from get_anon_bdev. > + */ > +static int unnamed_dev_start = 1; > > int get_anon_bdev(dev_t *p) > {
Very nice, I'll go queue this one up instead of the other patch from Tejun. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
