On Mon, Apr 07, 2014 at 06:19:32PM +0100, David Vrabel wrote: > On 04/04/14 19:53, Konrad Rzeszutek Wilk wrote: > > The user can launch the guest in this sequence: > > > > xl create -p /vm.cfg [launch, but pause it] > > xl shutdown latest [sets control/shutdown=poweroff] > > xl unpause latest > > xl console latest [and see that the guest has completely > > ignored the shutdown request] > > > > In reality the guest hasn't ignored it. It registers a watch > > and gets a notification that there is value. It then calls > > the shutdown_handler which ends up calling orderly_shutdown. > > > > Unfortunately that is so early in the bootup that there > > are no user-space. Which means that the orderly_shutdown fails. > > But since the force flag was set to false it continues on without > > reporting. > > > > What we really want to is to use the force when we are in the > > SYSTEM_BOOTING state and not use the 'force' when SYSTEM_RUNNING. > > > > However, if we are in the running state - and the shutdown command > > has been given before the user-space has been setup, there is nothing > > we can do. Worst yet, we stop ignoring the 'xl shutdown' requests! > > > > As such, the other part of this patch is to only stop ignoring > > the 'xl shutdown' when we are truly in the power off sequence. > > > > That means the user can do multiple 'xl shutdown' and we will try > > to act on them instead of ignoring them. > > Applied to devel/for-linus-3.15 > > > Fixes-Bug: http://bugs.xenproject.org/xen/bug/6 > > Reported-by: Alex Bligh <a...@alex.org.uk> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > [v2: Add switch statement] > > [v3: Add a reboot notifier] > > Can you put this version information after the --- in future?
Aye. > > Thanks. > > David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/