brd is effectively a thinly provisioned device.  Thinly provisioned
devices return -ENOSPC when they can't write a new block.  -ENOMEM is
an implementation detail that callers shouldn't know.

Acked-by: Dave Chinner <da...@fromorbit.com>
Signed-off-by: Matthew Wilcox <matthew.r.wil...@intel.com>
---
 drivers/block/brd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 807d3d5..c7d138e 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -200,11 +200,11 @@ static int copy_to_brd_setup(struct brd_device *brd, 
sector_t sector, size_t n)
 
        copy = min_t(size_t, n, PAGE_SIZE - offset);
        if (!brd_insert_page(brd, sector))
-               return -ENOMEM;
+               return -ENOSPC;
        if (copy < n) {
                sector += copy >> SECTOR_SHIFT;
                if (!brd_insert_page(brd, sector))
-                       return -ENOMEM;
+                       return -ENOSPC;
        }
        return 0;
 }
@@ -384,7 +384,7 @@ static int brd_direct_access(struct block_device *bdev, 
sector_t sector,
                return -ERANGE;
        page = brd_insert_page(brd, sector);
        if (!page)
-               return -ENOMEM;
+               return -ENOSPC;
        *kaddr = page_address(page);
        *pfn = page_to_pfn(page);
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to