While auditing the usage of lock_device_hotplug_sysfs() for implementing
it in another way in following patch, it seems to me that the code here
is to add/remove device, and the files probe/release for cpu bus
themselves won't be removed.
So it seems to me there is no s_active related deadlock here, and we
could just use lock_device_hotplug().
Signed-off-by: Li Zhong <zh...@linux.vnet.ibm.com>
---
drivers/base/cpu.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index 006b1bc..9483225 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -88,9 +88,7 @@ static ssize_t cpu_probe_store(struct device *dev,
ssize_t cnt;
int ret;
- ret = lock_device_hotplug_sysfs();
- if (ret)
- return ret;
+ lock_device_hotplug();
cnt = arch_cpu_probe(buf, count);
@@ -106,9 +104,7 @@ static ssize_t cpu_release_store(struct device *dev,
ssize_t cnt;
int ret;
- ret = lock_device_hotplug_sysfs();
- if (ret)
- return ret;
+ lock_device_hotplug();
cnt = arch_cpu_release(buf, count);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
