On pon, 2014-04-21 at 21:02 +0900, Chanwoo Choi wrote: > This patch use devm_extcon_dev_allocate() to simplify the memory control > of extcon device. > > Signed-off-by: Chanwoo Choi <[email protected]> > --- > drivers/extcon/extcon-max77693.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Krzysztof Kozlowski <[email protected]> Best regards, Krzysztof > diff --git a/drivers/extcon/extcon-max77693.c > b/drivers/extcon/extcon-max77693.c > index f0f18e2..2e15a24 100644 > --- a/drivers/extcon/extcon-max77693.c > +++ b/drivers/extcon/extcon-max77693.c > @@ -1175,8 +1175,8 @@ static int max77693_muic_probe(struct platform_device > *pdev) > } > > /* Initialize extcon device */ > - info->edev = devm_kzalloc(&pdev->dev, sizeof(struct extcon_dev), > - GFP_KERNEL); > + info->edev = devm_extcon_dev_allocate(&pdev->dev, > + max77693_extcon_cable); > if (!info->edev) { > dev_err(&pdev->dev, "failed to allocate memory for extcon\n"); > ret = -ENOMEM; > @@ -1184,14 +1184,13 @@ static int max77693_muic_probe(struct platform_device > *pdev) > } > info->edev->name = DEV_NAME; > info->edev->dev.parent = &pdev->dev; > - info->edev->supported_cable = max77693_extcon_cable; > + > ret = devm_extcon_dev_register(&pdev->dev, info->edev); > if (ret) { > dev_err(&pdev->dev, "failed to register extcon device\n"); > goto err_irq; > } > > - > /* Initialize MUIC register by using platform data or default data */ > if (pdata && pdata->muic_data) { > init_data = pdata->muic_data->init_data; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
