On 23/04/14 00:12, Marek Belisko wrote:

>  static int td028ttec1_panel_probe(struct spi_device *spi)
>  {
>       struct panel_drv_data *ddata;
> @@ -418,6 +436,10 @@ static int td028ttec1_panel_probe(struct spi_device *spi)
>               r = td028ttec1_panel_probe_pdata(spi);
>               if (r)
>                       return r;
> +     } else if (spi->dev.of_node) {
> +             r = td028ttec1_probe_of(spi);
> +             if (r)
> +                     return r;
>       } else {
>               return -ENODEV;
>       }
> @@ -463,6 +485,13 @@ static int td028ttec1_panel_remove(struct spi_device 
> *spi)
>       return 0;
>  }
>  
> +static const struct of_device_id td028ttec1_of_match[] = {
> +     { .compatible = "toppoly,td028ttec1", },

We need to hack a bit here for the time being. You need to have
"omapdss," prefix for the compatible string in the driver, and add the
panel's compatible string to arch/arm/mach-omap2/display.c:
dss_compat_conv_list.

The reason for this is that the drivers are omap specific, but the DT
data is not.

Otherwise looks good to me.

 Tomi


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to