Acked-by: Srikar Dronamraju <sri...@linux.vnet.ibm.com>
(with 2 nits that you can ignore)

>               done = tu->filter.nr_systemwide ||
> -                     event->parent || event->attr.enable_on_exec ||
> +                     (event->hw.tp_target->flags & PF_EXITING) ||
>                       uprobe_filter_event(tu, event);
> -             list_add(&event->hw.tp_list, &tu->filter.perf_events);
>       } else {
> +             tu->filter.nr_systemwide--;
>               done = tu->filter.nr_systemwide;
> -             tu->filter.nr_systemwide++;
>       }

Nit: I think 2 lines can be made into
 done = --tu->filter.nr_systemwide;


<snipped>
>               done = tu->filter.nr_systemwide ||
> -                     (event->hw.tp_target->flags & PF_EXITING) ||
> +                     event->parent || event->attr.enable_on_exec ||
>                       uprobe_filter_event(tu, event);
> +             list_add(&event->hw.tp_list, &tu->filter.perf_events);
>       } else {
> -             tu->filter.nr_systemwide--;
>               done = tu->filter.nr_systemwide;
> +             tu->filter.nr_systemwide++;
>       }

Nit: Similarly lines can be made into
 done = tu->filter.nr_systemwide++;


-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to