On Thu, Apr 24, 2014 at 10:55:58PM +0100, Al Viro wrote: > On Thu, Apr 24, 2014 at 01:34:14PM -0400, Sasha Levin wrote: > > > > Why does that code bother with destroying/creating that sucker > > > dynamically? > > > Is there any point at all? > > > > I'm not sure about the dynamic allocation part, but I fear that if we just > > switch to using static allocations it'll hide the underlying issue that > > triggered this bug instead of fixing it. > > FWIW, slub.c variant of kmem_cache_destroy() is buggered - struct kobject > embedded into struct kmem_cache, its ktype is slab_ktype, which has > NULL ->release()...
BTW, if your config has CONFIG_DEBUG_KOBJECT_RELEASE, that's exactly where that warning comes from. Got broken by commit b7454a, Author: Glauber Costa <glom...@parallels.com> Date: Fri Oct 19 18:20:25 2012 +0400 mm/sl[au]b: Move slabinfo processing to slab_common.c We *do* need ->release(). Greg and guilty parties Cc'd... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/