On Fri, Apr 25, 2014 at 09:42:18AM +0900, Chanwoo Choi wrote: > This patch use devm_extcon_dev_allocate() to simplify the memory control > of extcon device. > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlow...@samsung.com>
Reviewed-by: Felipe Balbi <ba...@ti.com>
> ---
> drivers/extcon/extcon-max8997.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 804a446..d9f7f1b 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -699,16 +699,15 @@ static int max8997_muic_probe(struct platform_device
> *pdev)
> }
>
> /* External connector */
> - info->edev = devm_kzalloc(&pdev->dev, sizeof(struct extcon_dev),
> - GFP_KERNEL);
> - if (!info->edev) {
> + info->edev = devm_extcon_dev_allocate(&pdev->dev, max8997_extcon_cable);
> + if (IS_ERR(info->edev)) {
> dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
> ret = -ENOMEM;
> goto err_irq;
> }
> info->edev->name = DEV_NAME;
> info->edev->dev.parent = &pdev->dev;
> - info->edev->supported_cable = max8997_extcon_cable;
> +
> ret = devm_extcon_dev_register(&pdev->dev, info->edev);
> if (ret) {
> dev_err(&pdev->dev, "failed to register extcon device\n");
> --
> 1.8.0
>
--
balbi
signature.asc
Description: Digital signature
