Fri, 25 Apr 2014 10:26:40 -0700 от Greg KH <gre...@linuxfoundation.org>:
> On Thu, Apr 24, 2014 at 08:56:06PM -0400, j...@ringle.org wrote:
> > From: Jon Ringle <jrin...@gridpoint.com>
> >
> > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel
> > high performance UART. The SC16IS7xx's internal register set is
> > backward-compatible with the widely used and widely popular 16C450.
> >
> > The SC16IS7xx also provides additional advanced features such as
> > auto hardware and software flow control, automatic RS-485 support, and
> > software reset.
> >
> > Signed-off-by: Jon Ringle <jrin...@gridpoint.com>
> > ---
> > drivers/tty/serial/Kconfig | 9 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/sc16is7xx.c | 1279
> > ++++++++++++++++++++++++++++++++++++++
> > include/uapi/linux/serial_core.h | 3 +
> > 4 files changed, 1292 insertions(+)
> > create mode 100644 drivers/tty/serial/sc16is7xx.c
>
> I get a few build warnings with this patch applied:
>
> drivers/tty/serial/sc16is7xx.c:1059:12: warning: ‘sc16is7xx_probe’ defined
> but not used [-Wunused-function]
> static int sc16is7xx_probe(struct device *dev,
> ^
> drivers/tty/serial/sc16is7xx.c:1175:12: warning: ‘sc16is7xx_remove’ defined
> but not used [-Wunused-function]
> static int sc16is7xx_remove(struct device *dev)
> ^
> drivers/tty/serial/sc16is7xx.c:1214:29: warning: ‘regcfg’ defined but not
> used [-Wunused-variable]
> static struct regmap_config regcfg = {
> ^
>
> Can you send a follow-on patch to fix them?
Seems this just should contain: "depends on I2C" in the Kconfig.
---
