On 29.04.14 09:22:20, Masanari Iida wrote:
> Fix format string mismatch in oprofile_perf_create_files.
Please provide a compiler warning.
>
> Signed-off-by: Masanari Iida <standby2...@gmail.com>
> ---
> drivers/oprofile/oprofile_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/oprofile/oprofile_perf.c
> b/drivers/oprofile/oprofile_perf.c
> index d5b2732..968e6dc 100644
> --- a/drivers/oprofile/oprofile_perf.c
> +++ b/drivers/oprofile/oprofile_perf.c
> @@ -146,7 +146,7 @@ static int oprofile_perf_create_files(struct dentry *root)
unsigned int i;
for (i = 0; i < num_counters; i++) {
> struct dentry *dir;
> char buf[4];
>
> - snprintf(buf, sizeof buf, "%d", i);
> + snprintf(buf, sizeof buf, "%u", i);
Since num_counters is int we better fix this by changing the i
declaration to int which avoids comparing unsigned/signed.
-Robert
> dir = oprofilefs_mkdir(root, buf);
> oprofilefs_create_ulong(dir, "enabled",
> &counter_config[i].enabled);
> oprofilefs_create_ulong(dir, "event", &counter_config[i].event);
> --
> 2.0.0.rc1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
