> On Wed, 30 Apr 2014 21:55:07 +0530
> Raghavendra Ganiga <ravi23gan...@gmail.com> wrote:
>> +static int ds1343_proc(struct device *dev, struct seq_file *seq)
>> +{
>> + struct ds1343_priv *priv = dev_get_drvdata(dev);
>> + unsigned int data;
>> + unsigned char alarm_mode = 0;
>> + const char *alarm_str, *diodes = "disabled", *resistors = " ";
>> +
>> + regmap_read(priv->map, DS1343_CONTROL_REG, &data);
> is this thing really useful? what about having sysfs entries
> instead?
i am replacing the proc interface with the sysfs entries
also removing the unnecessary parameters. i am adding the
following parameters as sysfs entries
1. glitch filter read and write parameter
2. alarm status read parameter
3. alarm mode read parameter
4. trickle charger read parameter
and i am removing the proc interface.
is the above implementation ok as per your last comment
on the proc interface. please provide the feedback.
Thanks and regards
Raghavendra Chandra Ganiga
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
