On Fri, 25 Apr 2014 12:10:32 +0400 Cyrill Gorcunov <gorcu...@openvz.org> wrote:
> Tracking dirty status on 2 level pages requires very ugly macros > and taking into account how old the machines who can operate > without PAE mode only are, lets drop soft dirty tracker from > them for code simplicity (note I can't drop all the macros > from 2 level pages by now since _PAGE_BIT_PROTNONE and > _PAGE_BIT_FILE are still used even without tracker). > > Linus proposed to completely rip off softdirty support on > x86-32 (even with PAE) and since for CRIU we're not planning > to support native x86-32 mode, lets do that. > > (Softdirty tracker is relatively new feature which mostly used > by CRIU so I don't expect if such API change would cause problems > on userspace). i386 allnoconfig: In file included from /usr/src/25/arch/x86/include/asm/pgtable.h:886, from include/linux/mm.h:51, from include/linux/suspend.h:8, from arch/x86/kernel/asm-offsets.c:12: include/asm-generic/pgtable.h:414: error: redefinition of 'pte_soft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:300: note: previous definition of 'pte_soft_dirty' was here include/asm-generic/pgtable.h:419: error: redefinition of 'pmd_soft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:305: note: previous definition of 'pmd_soft_dirty' was here include/asm-generic/pgtable.h:424: error: redefinition of 'pte_mksoft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:310: note: previous definition of 'pte_mksoft_dirty' was here include/asm-generic/pgtable.h:429: error: redefinition of 'pmd_mksoft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:315: note: previous definition of 'pmd_mksoft_dirty' was here include/asm-generic/pgtable.h:434: error: redefinition of 'pte_swp_mksoft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:868: note: previous definition of 'pte_swp_mksoft_dirty' was here include/asm-generic/pgtable.h:439: error: redefinition of 'pte_swp_soft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:874: note: previous definition of 'pte_swp_soft_dirty' was here include/asm-generic/pgtable.h:444: error: redefinition of 'pte_swp_clear_soft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:880: note: previous definition of 'pte_swp_clear_soft_dirty' was here include/asm-generic/pgtable.h:449: error: redefinition of 'pte_file_clear_soft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:320: note: previous definition of 'pte_file_clear_soft_dirty' was here include/asm-generic/pgtable.h:454: error: redefinition of 'pte_file_mksoft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:325: note: previous definition of 'pte_file_mksoft_dirty' was here include/asm-generic/pgtable.h:459: error: redefinition of 'pte_file_soft_dirty' /usr/src/25/arch/x86/include/asm/pgtable.h:330: note: previous definition of 'pte_file_soft_dirty' was here -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/