On Thu, 24 Feb 2005, Andrew Morton wrote:
> 
> Although a better fix might be to make __iounmap() behave symmetrically:
> 
>       if ((long)addr >= phys_to_virt(0xA0000) &&
>                       (long)addr < phys_to_virt(0x100000))
>               return;
> 
> but that's not quite right, because we're assuming that the range to be
> unmapped is wholly within the PCI/ISA region.  Without a VMA there just
> isn't enough info to determine that.
> 
> Does anyone have any preferences?

I think the "as symmetric as possible" thing is probably the thing to do. 
It might not be perfect in theory, but hey, practice is what matters. And 
in practice it's the "right thing", I think.

                Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to