> A function called clear_obj_pfmemalloc() doesn't indicate it's returning > anything, I think the vast majority of people would believe that it > returns void just as it does. There's no complier generated code > optimization with this patch and
> I'm not sure it's even correct since > you're now clearing after doing recheck_pfmemalloc_active(). I thought this through before rearranging the code. recheck_pfmemalloc_active() checks global lists, but __ac_get_obj() is doing clear_obj_pfmemalloc on a local variable. I think it does make sense to remove the pointless "return;" in set_obj_pfmemalloc(), however. Not sure it's worth asking someone to merge it, though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
