On Wed, May 07, 2014 at 07:43:24PM -0700, Paul E. McKenney wrote: > On Wed, May 07, 2014 at 06:54:08PM -0700, Josh Triplett wrote: > > On Wed, May 07, 2014 at 04:52:40PM -0700, Paul E. McKenney wrote: > > > On Wed, May 07, 2014 at 02:22:19PM -0700, j...@joshtriplett.org wrote: > > > > On Mon, Apr 28, 2014 at 05:24:55PM -0700, Paul E. McKenney wrote: > > > > > From: "Paul E. McKenney" <paul...@linux.vnet.ibm.com> > > > > > > > > > > Some environments require some variation on "make defconfig" to > > > > > initialize > > > > > the .config file. This commit therefore adds a --defconfig argument > > > > > to > > > > > allow this to be specified. The default value is of course > > > > > "defconfig". > > > > > > > > > > Signed-off-by: Paul E. McKenney <paul...@linux.vnet.ibm.com> > > > > > > > > <bikeshed color="blue"> > > > > "--defconfig randconfig" or "--defconfig allyesconfig" or similar seems > > > > rather odd; how about calling it --kconfig or similar? > > > > </bikeshed> > > > > > > Some day I am going to have to feed that to a browser and see what > > > happens. ;-) > > > > > > I must confess that I hadn't considered feeding randconfig or allyesconfig > > > to that argument, partly because I figured that I would have to also > > > supply Kconfig constraints in those cases in order to ensure that the > > > resulting kernel would actually run under qemu. I was instead thinking > > > in terms of a --configs option beginning with "RAND", which would pick > > > up the Kconfig constraints from the appropriate configs directory, > > > for example: > > > > > > tools/testing/selftests/rcutorture/configs/rcu/RAND1 > > > > > > That said, I haven't thought that far down that path. > > > > > > So for the --defconfig argument, I was thinking more in terms of things > > > like pseries_defconfig or versatile_defconfig. > > > > Ah, I see. --defconfig specifies the base configuration, while > > --configs specifies the constraints. In that case, how about > > --baseconfig? It might still make sense to pass --baseconfig > > allnoconfig or --baseconfig allyesconfig or --baseconfig randconfig, > > given a sufficiently complete constraints file. > > My choice of name was guided by the following: > > $ find arch -name '*defconfig*' -print | wc -l > 469 > > When I try baseconfig: > > $ find arch -name '*baseconfig*' -print | wc -l > 0 > > Don't get me wrong, you might be correct here. But the thing is that > I like being able to specify all tests in one go. That means that I > want to still be able to run my current defconfig-based config files > (e.g., TREE01) when I get a randconfig-based setup going. So I would > like to be able to specify something like: > > sh kvm.sh --defconfig pseries_defconfig --configs "TREE01 RAND01"
Fair enough. Reviewed-by: Josh Triplett <j...@joshtriplett.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
